dbTalk Databases Forums  

[DOCS] Cannot build docs on Ubuntu 10.04?

mailing.database.pgsql-docs mailing.database.pgsql-docs


Discuss [DOCS] Cannot build docs on Ubuntu 10.04? in the mailing.database.pgsql-docs forum.



Reply
 
Thread Tools Display Modes
  #21  
Old   
Tom Lane
 
Posts: n/a

Default Re: [DOCS] Cannot build docs on Ubuntu 10.04? - 03-21-2012 , 10:12 PM






I wrote:
Quote:
Maybe the Makefile should just error out if COLLATEINDEX isn't set,
rather than trying a "fallback" value that configure has already
determined isn't going to work.
I looked at this a bit closer, and figured out why the Makefile is
trying an apparently pointless case: the test implemented in configure
is wrong! In at least some installations of docbook, for instance the
ancient one I've got in captivity on my HPUX box, collateindex.pl is
provided in $(DOCBOOKSTYLE)/bin/, but *it is not marked executable*.
This causes AC_PATH_PROGS to not consider it valid. However, the docs
Makefile is coded to invoke the script via $(PERL) $(COLLATEINDEX),
which is presumably done precisely to be able to cope with
not-executable scripts.

So I think we should adjust the configure test to accept
$(DOCBOOKSTYLE)/bin/collateindex.pl if it is readable, whether or not it
is executable, and only use the Autoconf macro if we fall back to
searching PATH for collateindex.pl. Having done that, it should be safe
to simplify the Makefile to throw error if COLLATEINDEX isn't set.

regards, tom lane

--
Sent via pgsql-docs mailing list (pgsql-docs (AT) postgresql (DOT) org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

Reply With Quote
Reply




Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off



Powered by vBulletin Version 3.5.3
Copyright ©2000 - 2012, Jelsoft Enterprises Ltd.