dbTalk Databases Forums  

Re: [HACKERS] [BUGS] Autocomplete <TAB> on Postgres7.4beta5 not working?

mailing.database.pgsql-bugs mailing.database.pgsql-bugs


Discuss Re: [HACKERS] [BUGS] Autocomplete <TAB> on Postgres7.4beta5 not working? in the mailing.database.pgsql-bugs forum.



Reply
 
Thread Tools Display Modes
  #1  
Old   
Tom Lane
 
Posts: n/a

Default Re: [HACKERS] [BUGS] Autocomplete <TAB> on Postgres7.4beta5 not working? - 10-28-2003 , 04:51 PM






Alvaro Herrera Munoz <alvherre (AT) dcc (DOT) uchile.cl> writes:
Quote:
I found it very irritating at first, but when I discovered that I could
tab my way to syscatalogs by using "pg_catalog." as prefix, I started
feeling it was actually a nice behavior.
Hm. Okay, Ian isn't completely alone then ;-)

I tried out that approach just now, though, and found that I still had
to type at least "pg_c" before I could get any tab completion help at
all. Another odd thing was that after completing "pg_catalog.", it
wouldn't go any further --- one must type "p" here, even though all the
possible completions begin "pg_". (Possibly that could be fixed, but
I don't know readline's behavior well enough to be sure.) So that's
five typed characters and two tabs before one starts getting into the
system catalogs. That seems like a lot of typing. If Ian were willing
to type one more character of his p-something table names before hitting
tab (I assume he's not calling them pg-something), then he'd not have a
problem with the availability of tab completion for system catalogs.
I think saving one keystroke for p-something user tables is a poor
return for requiring seven keystrokes for system catalogs.

Anyway, it seems like we need a vote to see how many people prefer
each choice.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to majordomo (AT) postgresql (DOT) org


Reply With Quote
  #2  
Old   
Joe Conway
 
Posts: n/a

Default Re: [HACKERS] [BUGS] Autocomplete <TAB> on Postgres7.4beta5 not working? - 10-28-2003 , 04:56 PM






Alvaro Herrera Munoz wrote:
Quote:
On Tue, Oct 28, 2003 at 04:48:59PM -0500, Tom Lane wrote:
AFAICT there was no discussion about this issue when the patch was
proposed and applied. But now that the point is raised I have to say
that I don't like this change. I don't think system catalogs should be
excluded from tab completion. They never were before 7.4, and I have
not seen anyone complaining about that, other than Ian.

I found it very irritating at first, but when I discovered that I could
tab my way to syscatalogs by using "pg_catalog." as prefix, I started
feeling it was actually a nice behavior.

I found it similarly irritating at first, and it continues to irritate
me. But that may be because I use system tables more frequently than the
average Joe ;-)

I guess I'd be happy to see tab completion reinstated for system tables
(except toast tables as Tom suggested nearby), but I don't feel
particularly zealous about it.

Joe


---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://archives.postgresql.org


Reply With Quote
  #3  
Old   
Ian Barwick
 
Posts: n/a

Default Re: [HACKERS] [BUGS] Autocomplete <TAB> on Postgres7.4beta5 not working? - 10-28-2003 , 05:05 PM



On Tuesday 28 October 2003 23:47, Tom Lane wrote:
Quote:
Alvaro Herrera Munoz <alvherre (AT) dcc (DOT) uchile.cl> writes:
I found it very irritating at first, but when I discovered that I could
tab my way to syscatalogs by using "pg_catalog." as prefix, I started
feeling it was actually a nice behavior.

Hm. Okay, Ian isn't completely alone then ;-)

I tried out that approach just now, though, and found that I still had
to type at least "pg_c" before I could get any tab completion help at
all. Another odd thing was that after completing "pg_catalog.", it
wouldn't go any further --- one must type "p" here, even though all the
possible completions begin "pg_". (Possibly that could be fixed, but
I don't know readline's behavior well enough to be sure.)
I'm not sure whether it's intended or not, but explicitly adding
pg_catalog to the search path alleviates this.

Quote:
So that's
five typed characters and two tabs before one starts getting into the
system catalogs. That seems like a lot of typing. If Ian were willing
to type one more character of his p-something table names before hitting
tab (I assume he's not calling them pg-something),
Err ;-)

db=> \d p
page_template_cache pg_ts_cfg_pkey
page_template_cache_ov_idx pg_ts_cfgmap
page_template_cache_pkey pg_ts_cfgmap_pkey
page_template_cache_template_idx pg_ts_dict
pg_catalog. pg_ts_dict_pkey
pg_temp_1. pg_ts_parser
pg_toast. pg_ts_parser_pkey
pg_ts_cfg public.

(The pg_ts_% are all from tsearch2 BTW. Though, they`re all in
a schema of their own so explicitly addressing them would
work equally well too).
Quote:
then he'd not have a
problem with the availability of tab completion for system catalogs.
I'm sure I can live with that (one more character), at least until I finish
the brainwave input extension ;-).


Ian Barwick
barwick (AT) gmx (DOT) net



---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo (AT) postgresql (DOT) org so that your
message can get through to the mailing list cleanly


Reply With Quote
  #4  
Old   
Tom Lane
 
Posts: n/a

Default Re: [HACKERS] [BUGS] Autocomplete <TAB> on Postgres7.4beta5 not working? - 10-28-2003 , 05:49 PM



Ian Barwick <barwick (AT) gmx (DOT) net> writes:
Quote:
On Tuesday 28 October 2003 23:47, Tom Lane wrote:
Another odd thing was that after completing "pg_catalog.", it
wouldn't go any further --- one must type "p" here, even though all the
possible completions begin "pg_". (Possibly that could be fixed, but
I don't know readline's behavior well enough to be sure.)

I'm not sure whether it's intended or not, but explicitly adding
pg_catalog to the search path alleviates this.
It turns out that I unintentionally broke that a few days ago while
adding quote_ident() calls. I've repaired that damage, so now you can
go
pg_c<TAB><TAB>
and get
pg_catalog.pg_
which is one less keystroke than I claimed before. I still think it's
too many though ...

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 5: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faqs/FAQ.html


Reply With Quote
  #5  
Old   
Alvaro Herrera Munoz
 
Posts: n/a

Default Re: [HACKERS] [BUGS] Autocomplete <TAB> on Postgres7.4beta5 not working? - 10-30-2003 , 02:26 PM



On Tue, Oct 28, 2003 at 04:48:59PM -0500, Tom Lane wrote:

Quote:
AFAICT there was no discussion about this issue when the patch was
proposed and applied. But now that the point is raised I have to say
that I don't like this change. I don't think system catalogs should be
excluded from tab completion. They never were before 7.4, and I have
not seen anyone complaining about that, other than Ian.
I found it very irritating at first, but when I discovered that I could
tab my way to syscatalogs by using "pg_catalog." as prefix, I started
feeling it was actually a nice behavior.

--
Alvaro Herrera (<alvherre[@]dcc.uchile.cl>)
"Coge la flor que hoy nace alegre, ufana. ¿Quién sabe si nacera otra mañana?"

---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to majordomo (AT) postgresql (DOT) org)


Reply With Quote
  #6  
Old   
Christopher Kings-Lynne
 
Posts: n/a

Default Re: [HACKERS] [BUGS] Autocomplete <TAB> on Postgres7.4beta5 not working? - 10-30-2003 , 02:29 PM




Quote:
AFAICT there was no discussion about this issue when the patch was
proposed and applied. But now that the point is raised I have to say
that I don't like this change. I don't think system catalogs should be
excluded from tab completion. They never were before 7.4, and I have
not seen anyone complaining about that, other than Ian.

Comments anyone?
I had noticed that, but I had gotten used to it. I'm not fussed
particularly either way, really...

Chris



---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo (AT) postgresql (DOT) org so that your
message can get through to the mailing list cleanly


Reply With Quote
Reply




Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off



Powered by vBulletin Version 3.5.3
Copyright ©2000 - 2012, Jelsoft Enterprises Ltd.