dbTalk Databases Forums  

Re: [BUGS] Minor bug: Odd feedback on STDERR from PSQL for block comments

mailing.database.pgsql-bugs mailing.database.pgsql-bugs


Discuss Re: [BUGS] Minor bug: Odd feedback on STDERR from PSQL for block comments in the mailing.database.pgsql-bugs forum.



Reply
 
Thread Tools Display Modes
  #1  
Old   
Tom Lane
 
Posts: n/a

Default Re: [BUGS] Minor bug: Odd feedback on STDERR from PSQL for block comments - 11-08-2003 , 03:23 PM






Josh Berkus <josh (AT) agliodbs (DOT) com> writes:
Quote:
Here's a non-showstopper in 7.4RC1, but probably good to fix before RC2:
1) Create a file with *only* a block comment in it, or with a block comment as
the very last line.
2) run psql -f filename database
You will get some odd feedback on STDERR:
I can confirm the problem. It happens in more cases than Josh mentions,
as well:
-- running the file with \i also shows the problem
-- there can be blank lines and whitespace after the
block comment, and it still shows up.

Example: z.sql contains

--- snip ---
select 2+2;
/* block */


-- z
--- snip ---

regression=# \i z.sql
?column?
----------
4
(1 row)

psql:z.sql:5: regression=#

Peter, do you have time to look at this? You're probably more familiar
than I am with the psql command loop.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 4: Don't 'kill -9' the postmaster


Reply With Quote
  #2  
Old   
Tom Lane
 
Posts: n/a

Default Re: [BUGS] Minor bug: Odd feedback on STDERR from PSQL for block comments - 11-12-2003 , 05:58 PM






Josh Berkus <josh (AT) agliodbs (DOT) com> writes:
Quote:
This bug is still present in RC2. Are we going to fix it before release?
I have a fix (stupid case omission in AcceptResult()) but I am having
some trouble reaching the CVS server right at the moment ...

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://archives.postgresql.org


Reply With Quote
  #3  
Old   
Josh Berkus
 
Posts: n/a

Default Re: [BUGS] Minor bug: Odd feedback on STDERR from PSQL for block comments - 11-12-2003 , 06:24 PM



Guys,

Quote:
I can confirm the problem. It happens in more cases than Josh mentions,
as well:
-- running the file with \i also shows the problem
-- there can be blank lines and whitespace after the
block comment, and it still shows up.
This bug is still present in RC2. Are we going to fix it before release?=
=20=20=20
According to David W., it really screws up the error-detection code on=20
Bricolage, and I'd think that other applications might have the same proble=
m.

--=20
-Josh Berkus
Aglio Database Solutions
San Francisco


---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to majordomo (AT) postgresql (DOT) org


Reply With Quote
Reply




Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off



Powered by vBulletin Version 3.5.3
Copyright ©2000 - 2012, Jelsoft Enterprises Ltd.