![]() | |
![]() |
| | Thread Tools | Display Modes |
#1
| |||
| |||
|
|
Forwarded to -bugs in case it gets missed. This looks like it might be an issue to me, though I may well have overlooked something in my brief look at the code. |
#2
| |||
| |||
|
|
I don't know the reason, but that seems to be the problem, that I have found. isql crashes under conninfo_parse() on line "free(buf)". |
#3
| |||
| |||
|
|
-----Original Message----- From: Tom Lane [mailto:tgl (AT) sss (DOT) pgh.pa.us]=20 Sent: 02 August 2005 00:36 To: Dave Page Cc: pgsql-bugs (AT) postgresql (DOT) org; pgsql-odbc (AT) postgresql (DOT) org Subject: Re: [BUGS] Libpq free bug? (Was: [ODBC] IIS Postgres=20 ASP ADO - Problem)=20 =20 "Dave Page" <dpage (AT) vale-housing (DOT) co.uk> writes: Forwarded to -bugs in case it gets missed. This looks like it might be an issue to me, though I may well have overlooked something in my brief look at the code.=20 =20 There's nothing wrong with that code. The only modifiable=20 values in the record are the "val" pointers, which are handled correctly. See the comment: =20 * PQconninfoOptions[] is a constant static array that we use=20 to initialize * a dynamically allocated working copy. All the "val" fields in * PQconninfoOptions[] *must* be NULL. In a working=20 copy, non-null "val" * fields point to malloc'd strings that should be freed when=20 the working * array is freed (see PQconninfoFree). |
![]() |
| Thread Tools | |
| Display Modes | |
| |