 | |
Re: [BUGS] control character check in JSON type seems broken
mailing.database.pgsql-bugs mailing.database.pgsql-bugs
 |
| | Thread Tools | Display Modes |
#1
 
| |||
| |||
|
Re: [BUGS] control character check in JSON type seems broken -
06-08-2012
, 12:29 PM
|
In addition, error message above seems corrupted in my environment. Here we check not-escaped control character, so printing it with %c formatting might break log files. *How about using decimal or hex dump in such cases? And so is that. *IMO the error reporting in this module could stand to be reviewed altogether for compliance with our message guidelines. (For starters, why is it using errdetail_internal?) *I refrained from editorializing on-the-fly, but I'm not too pleased with what I saw. |
Should we just change all those to errdetail?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-bugs mailing list (pgsql-bugs (AT) postgresql (DOT) org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
#2
| |||
| |||
|
|
On Mon, Jun 4, 2012 at 8:48 PM, Tom Lane <tgl (AT) sss (DOT) pgh.pa.us> wrote: And so is that. *IMO the error reporting in this module could stand to be reviewed altogether for compliance with our message guidelines. (For starters, why is it using errdetail_internal?) *I refrained from editorializing on-the-fly, but I'm not too pleased with what I saw. Huh. I have no idea why I thought errdetail_internal was a good idea. Should we just change all those to errdetail? |
be translatable.
regards, tom lane
--
Sent via pgsql-bugs mailing list (pgsql-bugs (AT) postgresql (DOT) org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
|
« Previous Thread
|
Next Thread »
| Thread Tools | |
| Display Modes | |
Linear Mode
| |
Powered by vBulletin Version 3.5.3
Copyright ©2000 - 2013, Jelsoft Enterprises Ltd.
Copyright ©2000 - 2013, Jelsoft Enterprises Ltd.