The following bug has been logged on the website:

Bug reference: 6408
Logged by: YAMAMOTO Takashi
Email address: yamt (AT) mwd (DOT) biglobe.ne.jp
PostgreSQL version: Unsupported/Unknown
Operating system: NetBSD
Description:


hi,

the following patch fixes/updates/adds random comments in the tree.

YAMAMOTO Takashi

diff --git a/src/backend/access/gist/gist.c
b/src/backend/access/gist/gist.c
index ae6309d..0635301 100644
--- a/src/backend/access/gist/gist.c
+++ b/src/backend/access/gist/gist.c
@@ -253,7 +253,7 @@ gistplacetopage(Relation rel, Size freespace, GISTSTATE
*giststate,
}

/*
- * Now that we know whick blocks the new pages go to, set up downlink
+ * Now that we know which blocks the new pages go to, set up downlink
* tuples to point to them.
*/
for (ptr = dist; ptr; ptr = ptr->next)
diff --git a/src/backend/access/gist/gistproc.c
b/src/backend/access/gist/gistproc.c
index 7220b39..002a1ed 100644
--- a/src/backend/access/gist/gistproc.c
+++ b/src/backend/access/gist/gistproc.c
@@ -1,7 +1,8 @@

/*-------------------------------------------------------------------------
*
* gistproc.c
- * Support procedures for GiSTs over 2-D objects (boxes, polygons,
circles).
+ * Support procedures for GiSTs over 2-D objects (boxes, polygons,
circles,
+ * points).
*
* This gives R-tree behavior, with Guttman's poly-time split algorithm.
*
diff --git a/src/backend/access/gist/gistsplit.c
b/src/backend/access/gist/gistsplit.c
index 33b071e..05b489e 100644
--- a/src/backend/access/gist/gistsplit.c
+++ b/src/backend/access/gist/gistsplit.c
@@ -29,7 +29,7 @@ typedef struct

/*
* Forms unions of subkeys after page split, but
- * uses only tuples aren't in groups of equalent tuples
+ * uses only tuples aren't in groups of equivalent tuples
*/
static void
gistunionsubkeyvec(GISTSTATE *giststate, IndexTuple *itvec,
@@ -201,7 +201,7 @@ do { \
/*
* adjust left and right unions according to splits by previous
* split by firsts columns. This function is called only in case
- * when pickSplit doesn't support subspplit.
+ * when pickSplit doesn't support subsplit.
*/

static void
@@ -503,8 +503,8 @@ gistSplitHalf(GIST_SPLITVEC *v, int len)
}

/*
- * trys to split page by attno key, in a case of null
- * values move its to separate page.
+ * tries to split page by attno key, in a case of null
+ * values move to its separate page.
*/
void
gistSplitByKey(Relation r, Page page, IndexTuple *itup, int len, GISTSTATE
*giststate,
@@ -531,7 +531,7 @@ gistSplitByKey(Relation r, Page page, IndexTuple *itup,
int len, GISTSTATE *gist
{
/*
* Corner case: All keys in attno column are null, we should try to
- * split by keys in next column. It all keys in all columns are NULL
+ * split by keys in next column. If all keys in all columns are NULL
* just split page half by half
*/
v->spl_risnull[attno] = v->spl_lisnull[attno] = TRUE;
@@ -582,7 +582,7 @@ gistSplitByKey(Relation r, Page page, IndexTuple *itup,
int len, GISTSTATE *gist
{
/*
* simple case: left and right keys for attno column are
- * equial
+ * equal
*/
gistSplitByKey(r, page, itup, len, giststate, v, entryvec, attno + 1);
}
diff --git a/src/backend/access/gist/gistutil.c
b/src/backend/access/gist/gistutil.c
index ad27b63..8039b5d 100644
--- a/src/backend/access/gist/gistutil.c
+++ b/src/backend/access/gist/gistutil.c
@@ -22,7 +22,7 @@
#include "utils/builtins.h"

/*
- * static *S used for temrorary storage (saves stack and palloc() call)
+ * static *S used for temporary storage (saves stack and palloc() call)
*/

static Datum attrS[INDEX_MAX_KEYS];
@@ -148,8 +148,8 @@ gistfillitupvec(IndexTuple *vec, int veclen, int
*memlen)
}

/*
- * Make unions of keys in IndexTuple vector, return FALSE if itvec
contains
- * invalid tuple. Resulting Datums aren't compressed.
+ * Make unions of keys in IndexTuple vector.
+ * Resulting Datums aren't compressed.
*/

void
diff --git a/src/backend/access/gist/gistvacuum.c
b/src/backend/access/gist/gistvacuum.c
index 2cd4efa..f2a7a87 100644
--- a/src/backend/access/gist/gistvacuum.c
+++ b/src/backend/access/gist/gistvacuum.c
@@ -131,7 +131,7 @@ pushStackIfSplited(Page page, GistBDItem *stack)

/*
* Bulk deletion of all index entries pointing to a set of heap tuples and
- * check invalid tuples after crash recovery.
+ * check invalid tuples left after upgrade.
* The set of target tuples is specified via a callback routine that tells
* whether any given heap tuple (identified by ItemPointer) is being
deleted.
*
diff --git a/src/backend/access/transam/clog.c
b/src/backend/access/transam/clog.c
index 69b6ef3..33b5ca2 100644
--- a/src/backend/access/transam/clog.c
+++ b/src/backend/access/transam/clog.c
@@ -44,9 +44,10 @@
*
* Note: because TransactionIds are 32 bits and wrap around at 0xFFFFFFFF,
* CLOG page numbering also wraps around at
0xFFFFFFFF/CLOG_XACTS_PER_PAGE,
- * and CLOG segment numbering at 0xFFFFFFFF/CLOG_XACTS_PER_SEGMENT. We
need
- * take no explicit notice of that fact in this module, except when
comparing
- * segment and page numbers in TruncateCLOG (see CLOGPagePrecedes).
+ * and CLOG segment numbering at
+ * 0xFFFFFFFF/CLOG_XACTS_PER_PAGE/SLRU_PAGES_PER_SEGMENT. We need take no
+ * explicit notice of that fact in this module, except when comparing
segment
+ * and page numbers in TruncateCLOG (see CLOGPagePrecedes).
*/

/* We need two bits per xact, so four xacts fit in a byte */
diff --git a/src/backend/access/transam/slru.c
b/src/backend/access/transam/slru.c
index 30538ff..3049e01 100644
--- a/src/backend/access/transam/slru.c
+++ b/src/backend/access/transam/slru.c
@@ -280,6 +280,8 @@ SimpleLruZeroPage(SlruCtl ctl, int pageno)
* in a page from disk into an existing buffer. (Such an old page cannot
* have any interesting LSNs, since we'd have flushed them before writing
* the page in the first place.)
+ *
+ * This assumes that InvalidXLogRecPtr is bitwise-all-0.
*/
static void
SimpleLruZeroLSNs(SlruCtl ctl, int slotno)
diff --git a/src/backend/executor/nodeWindowAgg.c
b/src/backend/executor/nodeWindowAgg.c
index 5082a50..ce89ff2 100644
--- a/src/backend/executor/nodeWindowAgg.c
+++ b/src/backend/executor/nodeWindowAgg.c
@@ -1668,7 +1668,7 @@ ExecEndWindowAgg(WindowAggState *node)
}

/* -----------------
- * ExecRescanWindowAgg
+ * ExecReScanWindowAgg
* -----------------
*/
void
diff --git a/src/backend/storage/ipc/procarray.c
b/src/backend/storage/ipc/procarray.c
index 6ea0a28..ead4898 100644
--- a/src/backend/storage/ipc/procarray.c
+++ b/src/backend/storage/ipc/procarray.c
@@ -1220,7 +1220,7 @@ GetMaxSnapshotSubxidCount(void)
*
* We also update the following backend-global variables:
* TransactionXmin: the oldest xmin of any snapshot in use in the
- * current transaction (this is the same as MyProc->xmin).
+ * current transaction (this is the same as MyPgXact->xmin).
* RecentXmin: the xmin computed for the most recent snapshot. XIDs
* older than this are known not running any more.
* RecentGlobalXmin: the global xmin (oldest TransactionXmin across all
diff --git a/src/backend/utils/hash/hashfn.c
b/src/backend/utils/hash/hashfn.c
index 4cbdd13..11180bf 100644
--- a/src/backend/utils/hash/hashfn.c
+++ b/src/backend/utils/hash/hashfn.c
@@ -25,7 +25,7 @@


/*
- * string_hash: hash function for keys that are null-terminated strings.
+ * string_hash: hash function for keys that are NUL-terminated strings.
*
* NOTE: this is the default hash function if none is specified.
*/
diff --git a/src/include/access/gist.h b/src/include/access/gist.h
index 42ac63a..ed57bb7 100644
--- a/src/include/access/gist.h
+++ b/src/include/access/gist.h
@@ -89,7 +89,7 @@ typedef GISTPageOpaqueData *GISTPageOpaque;
* that corresponding spl_(r|l)datum already defined and
* PickSplit should use that value. PickSplit should always set
* spl_(r|l)datum_exists to false: GiST will check value to
- * control supportng this feature by PickSplit...
+ * control supporting this feature by PickSplit...
*/
typedef struct GIST_SPLITVEC
{



--
Sent via pgsql-bugs mailing list (pgsql-bugs (AT) postgresql (DOT) org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs

yamt (AT) mwd (DOT) biglobe.ne.jp writes:
Applied, thanks.

BTW, it took some manual effort to undo the line-wrapping that got done
on this posting. It'd be better to send patches directly to the
pgsql-hackers mailing list so you can append them as attachments.
Most mail programs are a bit more careful with attached files than with
inline text.

regards, tom lane

--
Sent via pgsql-bugs mailing list (pgsql-bugs (AT) postgresql (DOT) org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs

hi,

thanks.

ok, i'll do so next time.
i guess a note on the bug reporting form would help.

YAMAMOTO Takashi

--
Sent via pgsql-bugs mailing list (pgsql-bugs (AT) postgresql (DOT) org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs