dbTalk Databases Forums  

[BUGS] BUG #1490: contrib .sql.in sed command bogus

mailing.database.pgsql-bugs mailing.database.pgsql-bugs


Discuss [BUGS] BUG #1490: contrib .sql.in sed command bogus in the mailing.database.pgsql-bugs forum.



Reply
 
Thread Tools Display Modes
  #1  
Old   
Alexis Wilke
 
Posts: n/a

Default [BUGS] BUG #1490: contrib .sql.in sed command bogus - 02-20-2005 , 11:57 PM







The following bug has been logged online:

Bug reference: 1490
Logged by: Alexis Wilke
Email address: alexis (AT) m2osw (DOT) com
PostgreSQL version: 8.0.1
Operating system: Linux
Description: contrib .sql.in sed command bogus
Details:

Inside pgxs.mk I had to change the $$libdir into $(libdir ) to get the
proper path in the final .sql file:


ifneq (,$(MODULES)$(MODULE_big))
%.sql: %.sql.in
sed 's,MODULE_PATHNAME,$(libdir)/$*,g' $< >$@
endif

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo (AT) postgresql (DOT) org so that your
message can get through to the mailing list cleanly

Reply With Quote
  #2  
Old   
Tom Lane
 
Posts: n/a

Default Re: [BUGS] BUG #1490: contrib .sql.in sed command bogus - 02-21-2005 , 06:19 PM






"Alexis Wilke" <alexis (AT) m2osw (DOT) com> writes:
Quote:
Inside pgxs.mk I had to change the $$libdir into $(libdir ) to get the
proper path in the final .sql file:

Quote:
ifneq (,$(MODULES)$(MODULE_big))
%.sql: %.sql.in
sed 's,MODULE_PATHNAME,$(libdir)/$*,g' $< >$@
endif
This is not correct --- the substitution is supposed to be literally
"$libdir", and so the makefile is correct as-is. (I'm not sure why we
still bother with doing the sed conversion at all, except that if we
removed it you can be sure we'd think of some other thing we needed it
for ;-))

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://archives.postgresql.org


Reply With Quote
  #3  
Old   
alexis@m2osw.com
 
Posts: n/a

Default Re: [BUGS] BUG #1490: contrib .sql.in sed command bogus - 02-22-2005 , 11:47 PM



Hi Tom,

Indeed, with the correct version the $libdir will work in the .sql file.
Very good. 8-)

Alexis

On Mon, 21 Feb 2005, Tom Lane wrote:

Quote:
"Alexis Wilke" <alexis (AT) m2osw (DOT) com> writes:
Inside pgxs.mk I had to change the $$libdir into $(libdir ) to get the
proper path in the final .sql file:


ifneq (,$(MODULES)$(MODULE_big))
%.sql: %.sql.in
sed 's,MODULE_PATHNAME,$(libdir)/$*,g' $< >$@
endif

This is not correct --- the substitution is supposed to be literally
"$libdir", and so the makefile is correct as-is. (I'm not sure why we
still bother with doing the sed conversion at all, except that if we
removed it you can be sure we'd think of some other thing we needed it
for ;-))

regards, tom lane


---------------------------(end of broadcast)---------------------------
TIP 9: the planner will ignore your desire to choose an index scan if your
joining column's datatypes do not match


Reply With Quote
Reply




Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off



Powered by vBulletin Version 3.5.3
Copyright ©2000 - 2012, Jelsoft Enterprises Ltd.