dbTalk Databases Forums  

[BUGS] Broken CIDR: no fix in 7.4.6?

mailing.database.pgsql-bugs mailing.database.pgsql-bugs


Discuss [BUGS] Broken CIDR: no fix in 7.4.6? in the mailing.database.pgsql-bugs forum.



Reply
 
Thread Tools Display Modes
  #1  
Old   
Alexander M. Pravking
 
Posts: n/a

Default [BUGS] Broken CIDR: no fix in 7.4.6? - 11-12-2004 , 10:27 AM







As been said, in 7.4.5 CIDR data type has been accepted values with
non-zero bits to the right of >24-bit mask:

http://archives.postgresql.org/pgsql...0/msg00081.php

In CVS head src/backend/utils/adt/network.c (1.54) has a fix by Bruce,
but 7.4.6 still has 1.47.2.1 with no fix.

I wonder if I can safely use diff -r1.53 -r1.54 .../network.c to patch
7.4.6 sources...


--
Fduch M. Pravking

---------------------------(end of broadcast)---------------------------
TIP 5: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faqs/FAQ.html

Reply With Quote
  #2  
Old   
Bruce Momjian
 
Posts: n/a

Default Re: [BUGS] Broken CIDR: no fix in 7.4.6? - 11-12-2004 , 10:47 AM






Alexander M. Pravking wrote:
Quote:
As been said, in 7.4.5 CIDR data type has been accepted values with
non-zero bits to the right of >24-bit mask:

http://archives.postgresql.org/pgsql...0/msg00081.php

In CVS head src/backend/utils/adt/network.c (1.54) has a fix by Bruce,
but 7.4.6 still has 1.47.2.1 with no fix.

I wonder if I can safely use diff -r1.53 -r1.54 .../network.c to patch
7.4.6 sources...
Yes, you can, but you should be sure all your existing data is clean or
you will have problems with revalidating some of your data. We didn't
backpatch this fix because it was something that might break existing
bad data that got into your system.

--
Bruce Momjian | http://candle.pha.pa.us
pgman (AT) candle (DOT) pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo (AT) postgresql (DOT) org so that your
message can get through to the mailing list cleanly


Reply With Quote
  #3  
Old   
Alexander M. Pravking
 
Posts: n/a

Default Re: [BUGS] Broken CIDR: no fix in 7.4.6? - 11-12-2004 , 10:57 AM



On Fri, Nov 12, 2004 at 11:37:24AM -0500, Bruce Momjian wrote:
Quote:
Alexander M. Pravking wrote:

As been said, in 7.4.5 CIDR data type has been accepted values with
non-zero bits to the right of >24-bit mask:

http://archives.postgresql.org/pgsql...0/msg00081.php

In CVS head src/backend/utils/adt/network.c (1.54) has a fix by Bruce,
but 7.4.6 still has 1.47.2.1 with no fix.

I wonder if I can safely use diff -r1.53 -r1.54 .../network.c to patch
7.4.6 sources...

Yes, you can, but you should be sure all your existing data is clean or
you will have problems with revalidating some of your data. We didn't
backpatch this fix because it was something that might break existing
bad data that got into your system.
Good point.
Of course, I'll check, thanks.


--
Fduch M. Pravking

---------------------------(end of broadcast)---------------------------
TIP 7: don't forget to increase your free space map settings


Reply With Quote
Reply




Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off



Powered by vBulletin Version 3.5.3
Copyright ©2000 - 2012, Jelsoft Enterprises Ltd.