Re: [bug #7448] Patch to remove some warnings

#1

Korolyov Ilya wrote:

Quote:

Original custom.pl.patch has such line:

if (cmp = mysqlpp::sql_cmp(x.C$j , y.C$j ))

it give some additional warnings, so I propose to change it for:

if ((cmp = mysqlpp::sql_cmp(x.C$j , y.C$j)))

Two minor objections:

1. What compiler(s) emit these warnings, and what flags does it take to
make it happen?

2. I'd rather move the assignment out of the test part of the if
statement than just add some opaque parens, but I can take care of that.

--
MySQL++ Mailing List
For list archives: http://lists.mysql.com/plusplus
To unsubscribe: http://lists.mysql.com/plusplus?unsu...ie.nctu.edu.tw

#2

Королев Илья wrote:

Quote:

Give such warnings:
../../../include/table_types/stat_advdaily.h: In function 'int
sql_compare_DB_AdvDaily(const DB_AdvDaily&, const DB_AdvDaily&) [with
mysqlpp::sql_dummy_type dummy = sql_dummy]':

I didn't doubt that it gave the warning. I guessed what was being fixed
from the patch. I just wanted to know which compiler cared about this.

Quote:

2. I don't insist on my variant, it was just the simplest solution

I've applied my version of the change to the subversion tree. Test it
out, if you like. Thanks for the fix.

--
MySQL++ Mailing List
For list archives: http://lists.mysql.com/plusplus
To unsubscribe: http://lists.mysql.com/plusplus?unsu...ie.nctu.edu.tw

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Re: [bug #7448] Patch to remove some warnings

mailing.database.mysql-plusplus mailing.database.mysql-plusplus

Re: [bug #7448] Patch to remove some warnings - 10-17-2006 , 02:37 AM

Re: [bug #7448] Patch to remove some warnings - 10-17-2006 , 03:55 AM