dbTalk Databases Forums  

bugs in platform.h

mailing.database.mysql-plusplus mailing.database.mysql-plusplus


Discuss bugs in platform.h in the mailing.database.mysql-plusplus forum.



Reply
 
Thread Tools Display Modes
  #1  
Old   
AT
 
Posts: n/a

Default bugs in platform.h - 06-22-2006 , 06:52 PM






Hello,

mysql++ 2.1.1

I have found 4 (!) bugs in 2 (!) minutes in platform.h.

1. mysql.h is included AFTER platform.h in all .cpp, therefore
MYSQL_VERSION_ID is NOT defined in platform.h at all, but:

# if ((MYSQL_VERSION_ID > 40103).......

Workaround: include <mysql_version.h> before that directive.

2. The same place:

// The shutdown_level argument was added in MySQL 4.1.3 and in 5.0.1.

OK, but what we can see in realisation of this statement:

#if ((MYSQL_VERSION_ID > 40103) && (MYSQL_VERSION_ID < 49999)) || (MYSQL_VERSION_ID > 50001)
(bigger than 4.1.3 and NOT 4.1.3) and (less than 4.99.99 and NOT 4.99.99)
OR
(bigger than 5.0.1 and NOT 5.0.1)

Workaround:
#if ((MYSQL_VERSION_ID >= 40103) && (MYSQL_VERSION_ID <= 49999)) || (MYSQL_VERSION_ID >= 50001)


Too inaccurate work

--
Best regards,
Skipy mailto:skipyrich (AT) mail (DOT) ru


--
MySQL++ Mailing List
For list archives: http://lists.mysql.com/plusplus
To unsubscribe: http://lists.mysql.com/plusplus?unsu...ie.nctu.edu.tw


Reply With Quote
  #2  
Old   
AT
 
Posts: n/a

Default Re: bugs in platform.h - 06-23-2006 , 12:24 AM






Skipy Rich wrote:
Quote:
Workaround: include <mysql_version.h> before that directive.
Applied.

Quote:
Workaround:
#if ((MYSQL_VERSION_ID >= 40103) && (MYSQL_VERSION_ID <= 49999)) || (MYSQL_VERSION_ID >= 50001)
Applied.

Quote:
Too inaccurate work
Sigh...your efforts are appreciated, but you're not going to ingratiate
yourself with the community on effort alone. A good attitude helps, too.

If you find a bug, just explain the problem and provide a fix. As
you've seen, if it's a legitimate fix and I agree with how it's done,
it'll get applied. It's as simple as that. There's no need to insult
me and the rest of us who have worked on MySQL++ for free for your
benefit when you report the bug.

--
MySQL++ Mailing List
For list archives: http://lists.mysql.com/plusplus
To unsubscribe: http://lists.mysql.com/plusplus?unsu...ie.nctu.edu.tw



Reply With Quote
Reply




Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off



Powered by vBulletin Version 3.5.3
Copyright ©2000 - 2012, Jelsoft Enterprises Ltd.