![]() | |
![]() |
| | Thread Tools | Display Modes |
#11
| |||
| |||
|
|
Please remove that; if I thought either one was a good idea, I would have allowed it in the committed patch. Sequences are too small to be worth moving around, and may someday be reimplemented in a fashion that doesn't use up a separate disk file for each one. If we allow SET TABLESPACE on them we will be limiting our future flexibility for no useful gain. Why do we allow them to be created in tablespaces in the first place then? Seems like a bit of a misfeature? I mean we don't allow views in tablespaces... |
#12
| |||
| |||
|
|
Does this patch allow setting the tablespace of sequences as well? If so, then you will need to modify pg_dump of SERIAL sequences. Perhaps output a ALTER TABLE/SET TABLESPACE command after the CREATE TABLE definition to move the SERIAL sequence. The same argument applies if it allows moving indexes. (Unique and Primary Keys) Sequences no, toast tables no, indexes yes. So we need the latter part of the above-mentioned patch. Anyone? |
#13
| |||
| |||
|
|
Sequences are too small to be worth moving around, and may someday be reimplemented in a fashion that doesn't use up a separate disk file for each one. If we allow SET TABLESPACE on them we will be limiting our future flexibility for no useful gain. Why do we allow them to be created in tablespaces in the first place then? Seems like a bit of a misfeature? I mean we don't allow views in tablespaces... |
#14
| |||
| |||
|
|
Christopher Kings-Lynne <chriskl (AT) familyhealth (DOT) com.au> writes: Sequences are too small to be worth moving around, and may someday be reimplemented in a fashion that doesn't use up a separate disk file for each one. If we allow SET TABLESPACE on them we will be limiting our future flexibility for no useful gain. Why do we allow them to be created in tablespaces in the first place then? Seems like a bit of a misfeature? I mean we don't allow views in tablespaces... I had forgotten that the original patch allowed that. Personally I'd vote for taking it out, for the above-stated reasons --- any objections? If people do want to have it then we can instead change ALTER SET TABLESPACE to allow sequences; but we'd also need a nontrivial addition to pg_dump, so there had better be a better reason than "might be nice to have". regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 1: subscribe and unsubscribe commands go to majordomo (AT) postgresql (DOT) org |
#15
| |||
| |||
|
|
Christopher Kings-Lynne <chriskl (AT) familyhealth (DOT) com.au> writes: Sequences are too small to be worth moving around, and may someday be reimplemented in a fashion that doesn't use up a separate disk file for each one. If we allow SET TABLESPACE on them we will be limiting our future flexibility for no useful gain. Why do we allow them to be created in tablespaces in the first place then? Seems like a bit of a misfeature? I mean we don't allow views in tablespaces... I had forgotten that the original patch allowed that. Personally I'd vote for taking it out, for the above-stated reasons --- any objections? If people do want to have it then we can instead change ALTER SET TABLESPACE to allow sequences; but we'd also need a nontrivial addition to pg_dump, so there had better be a better reason than "might be nice to have". regards, tom lane |
#16
| |||
| |||
|
|
I had forgotten that the original patch allowed that. Personally I'd vote for taking it out, for the above-stated reasons --- any objections? |
#17
| |||
| |||
|
|
I had forgotten that the original patch allowed that. Personally I'd vote for taking it out, for the above-stated reasons --- any objections? I vote for taking it out. |
|
Chris !DSPAM:40f1f2de259842510072165! |
#18
| |||
| |||
|
|
Will toast go in the same tablespace as the base table? |
#19
| |||
| |||
|
|
On Mon, 12 Jul 2004, Christopher Kings-Lynne wrote: I vote for taking it out. Pull it. I added it intentionally but now I'm questioning my reasoning (which was, sequences might be accessed lots, people might want to put them somewhere intentionally). |
#20
| |||
| |||
|
|
In fact, now that I think of it, the patch-as-committed already introduces some serious headaches for pg_dump: it can't know for sure what name will be assigned to constraint indexes (pkey and unique indexes) so it has no good way to emit ALTER TABLE SET TABLESPACE commands for those indexes. |

![]() |
| Thread Tools | |
| Display Modes | |
| |