dbTalk Databases Forums  

Re: Cosmetic changes

comp.databases.postgresql.patches comp.databases.postgresql.patches


Discuss Re: Cosmetic changes in the comp.databases.postgresql.patches forum.



Reply
 
Thread Tools Display Modes
  #1  
Old   
Tom Lane
 
Posts: n/a

Default Re: Cosmetic changes - 10-01-2004 , 01:21 AM






Euler Taveira de Oliveira <eulerto (AT) yahoo (DOT) com.br> writes:
Quote:
This small patch correct a hint style and change from multiple to
single line comment because gettext seems not to like multiple line
comments. Then we could see the "translator: ..." in po files too.
I believe most of these changes are fixing comments that were written as
single lines to begin with, and were changed to multiline format by
pgindent which has extremely narrow (ahem) ideas about the appropriate
right margin for code and comments. Bruce, could we *please* fix
pgindent to not enforce a 72-column limit? 72 hasn't been interesting
since people stopped punching FORTRAN code into cards. 79 would be a
reasonable line length limit.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://archives.postgresql.org



Reply With Quote
  #2  
Old   
Bruce Momjian
 
Posts: n/a

Default Re: Cosmetic changes - 10-01-2004 , 08:11 PM






Tom Lane wrote:
Quote:
Euler Taveira de Oliveira <eulerto (AT) yahoo (DOT) com.br> writes:
This small patch correct a hint style and change from multiple to
single line comment because gettext seems not to like multiple line
comments. Then we could see the "translator: ..." in po files too.

I believe most of these changes are fixing comments that were written as
single lines to begin with, and were changed to multiline format by
pgindent which has extremely narrow (ahem) ideas about the appropriate
right margin for code and comments. Bruce, could we *please* fix
pgindent to not enforce a 72-column limit? 72 hasn't been interesting
since people stopped punching FORTRAN code into cards. 79 would be a
reasonable line length limit.
It was set to 75. Updated to 79. I assume you don't want a rerun now.

--
Bruce Momjian | http://candle.pha.pa.us
pgman (AT) candle (DOT) pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to majordomo (AT) postgresql (DOT) org



Reply With Quote
Reply




Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off



Powered by vBulletin Version 3.5.3
Copyright ©2000 - 2013, Jelsoft Enterprises Ltd.