dbTalk Databases Forums  

pgsql: There is no need for ReadBuffer() call sites to check that the

comp.databases.postgresql.committers comp.databases.postgresql.committers


Discuss pgsql: There is no need for ReadBuffer() call sites to check that the in the comp.databases.postgresql.committers forum.



Reply
 
Thread Tools Display Modes
  #1  
Old   
Neil Conway
 
Posts: n/a

Default pgsql: There is no need for ReadBuffer() call sites to check that the - 11-13-2004 , 08:04 PM






Log Message:
-----------
There is no need for ReadBuffer() call sites to check that the returned
buffer is valid, as ReadBuffer() will elog on error. Most of the call
sites of ReadBuffer() got this right, but this patch fixes those call
sites that did not.

Modified Files:
--------------
pgsql/src/backend/access/heap:
heapam.c (r1.180 -> r1.181)
(http://developer.postgresql.org/cvsw...1.180&r2=1.181)
pgsql/src/backend/commands:
analyze.c (r1.78 -> r1.79)
(http://developer.postgresql.org/cvsw...1=1.78&r2=1.79)
sequence.c (r1.117 -> r1.118)
(http://developer.postgresql.org/cvsw...1.117&r2=1.118)
trigger.c (r1.174 -> r1.175)
(http://developer.postgresql.org/cvsw...1.174&r2=1.175)

---------------------------(end of broadcast)---------------------------
TIP 9: the planner will ignore your desire to choose an index scan if your
joining column's datatypes do not match


Reply With Quote
Reply




Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off



Powered by vBulletin Version 3.5.3
Copyright ©2000 - 2013, Jelsoft Enterprises Ltd.