dbTalk Databases Forums  

Syntax error - what is wrong

comp.databases.oracle.misc comp.databases.oracle.misc


Discuss Syntax error - what is wrong in the comp.databases.oracle.misc forum.



Reply
 
Thread Tools Display Modes
  #1  
Old   
tni@nc.rr.com
 
Posts: n/a

Default Syntax error - what is wrong - 08-11-2006 , 05:01 PM






What is wrong with this?

create or replace PACKAGE DAL_TABLE_METHODS AS
TYPE T_CURSOR IS REF CURSOR;

PROCEDURE GET_EMP (
p_EMPNO IN NUMBER,
cur_EMP OUT T_CURSOR
);

PROCEDURE UPDATE_EMP (
pEMPNO IN NUMBER,
pENAME IN VARCHAR2,
pJOB IN VARCHAR2,
pMGR IN NUMBER,
pHIREDATE IN DATE,
pSAL IN NUMBER,
pCOMM IN NUMBER,
pDEPTNO IN NUMBER
);

PROCEDURE DELETE_EMP (
p_EMPNO IN NUMBER
);

PROCEDURE INSERT_EMP (
pEMPNO OUT NUMBER,
pENAME IN VARCHAR2,
pJOB IN VARCHAR2,
pMGR IN NUMBER,
pHIREDATE IN DATE,
pSAL IN NUMBER,
pCOMM IN NUMBER,
pDEPTNO IN NUMBER
);

END DAL_TABLE_METHODS;

CREATE OR REPLACE
PACKAGE BODY DAL_TABLE_METHODS AS

PROCEDURE GET_EMP (
p_EMPNO IN NUMBER,
cur_EMP OUT T_CURSOR
)
IS
BEGIN
OPEN cur_EMP FOR
SELECT
"EMPNO"
, "ENAME"
, "JOB"
, "MGR"
, "HIREDATE"
, "SAL"
, "COMM"
, "DEPTNO"
FROM EMP
WHERE (EMPNO = p_EMPNO);
END GET_EMP;

PROCEDURE UPDATE_EMP (
pEMPNO IN NUMBER,
pENAME IN VARCHAR2,
pJOB IN VARCHAR2,
pMGR IN NUMBER,
pHIREDATE IN DATE,
pSAL IN NUMBER,
pCOMM IN NUMBER,
pDEPTNO IN NUMBER
)
IS
BEGIN
UPDATE EMP
SET "ENAME" = pENAME
, "JOB" = pJOB
, "MGR" = pMGR
, "HIREDATE" = pHIREDATE
, "SAL" = pSAL
, "COMM" = pCOMM
, "DEPTNO" = pDEPTNO
WHERE (EMPNO = p_EMPNO);
END UPDATE_EMP;

PROCEDURE DELETE_EMP (
p_EMPNO IN NUMBER
)
IS
BEGIN
DELETE FROM EMP
WHERE (EMPNO = p_EMPNO);
END DELETE_EMP;

PROCEDURE INSERT_EMP (
pEMPNO OUT NUMBER,
pENAME IN VARCHAR2,
pJOB IN VARCHAR2,
pMGR IN NUMBER,
pHIREDATE IN DATE,
pSAL IN NUMBER,
pCOMM IN NUMBER,
pDEPTNO IN NUMBER
)
IS
BEGIN
pEMPNO := DEVELOPER.EMPNO_SEQUENCE.NEXTVAL;
INSERT INTO "EMP" (
"EMPNO"
,"ENAME"
,"JOB"
,"MGR"
,"HIREDATE"
,"SAL"
,"COMM"
,"DEPTNO"
)
VALUES (
pEMPNO
,pENAME
,pJOB
,pMGR
,pHIREDATE
,pSAL
,pCOMM
,pDEPTNO
);
END INSERT_EMP;
END DAL_TABLE_METHODS;


Reply With Quote
  #2  
Old   
G Quesnel
 
Posts: n/a

Default Re: Syntax error - what is wrong - 08-11-2006 , 05:14 PM






Just to make our life easy, what does it say if you type "show error"
right after the compile.
This typically refers to a line number or a text message regarding the
error.
Then if you posted the script with the line number, it should be easy
to spot the flaw.

Help us help you.


Reply With Quote
  #3  
Old   
DA Morgan
 
Posts: n/a

Default Re: Syntax error - what is wrong - 08-11-2006 , 05:31 PM



tni (AT) nc (DOT) rr.com wrote:
Quote:
What is wrong with this?

create or replace PACKAGE DAL_TABLE_METHODS AS
TYPE T_CURSOR IS REF CURSOR;

PROCEDURE GET_EMP (
p_EMPNO IN NUMBER,
cur_EMP OUT T_CURSOR
);

PROCEDURE UPDATE_EMP (
pEMPNO IN NUMBER,
pENAME IN VARCHAR2,
pJOB IN VARCHAR2,
pMGR IN NUMBER,
pHIREDATE IN DATE,
pSAL IN NUMBER,
pCOMM IN NUMBER,
pDEPTNO IN NUMBER
);

PROCEDURE DELETE_EMP (
p_EMPNO IN NUMBER
);

PROCEDURE INSERT_EMP (
pEMPNO OUT NUMBER,
pENAME IN VARCHAR2,
pJOB IN VARCHAR2,
pMGR IN NUMBER,
pHIREDATE IN DATE,
pSAL IN NUMBER,
pCOMM IN NUMBER,
pDEPTNO IN NUMBER
);

END DAL_TABLE_METHODS;

CREATE OR REPLACE
PACKAGE BODY DAL_TABLE_METHODS AS

PROCEDURE GET_EMP (
p_EMPNO IN NUMBER,
cur_EMP OUT T_CURSOR
)
IS
BEGIN
OPEN cur_EMP FOR
SELECT
"EMPNO"
, "ENAME"
, "JOB"
, "MGR"
, "HIREDATE"
, "SAL"
, "COMM"
, "DEPTNO"
FROM EMP
WHERE (EMPNO = p_EMPNO);
END GET_EMP;

PROCEDURE UPDATE_EMP (
pEMPNO IN NUMBER,
pENAME IN VARCHAR2,
pJOB IN VARCHAR2,
pMGR IN NUMBER,
pHIREDATE IN DATE,
pSAL IN NUMBER,
pCOMM IN NUMBER,
pDEPTNO IN NUMBER
)
IS
BEGIN
UPDATE EMP
SET "ENAME" = pENAME
, "JOB" = pJOB
, "MGR" = pMGR
, "HIREDATE" = pHIREDATE
, "SAL" = pSAL
, "COMM" = pCOMM
, "DEPTNO" = pDEPTNO
WHERE (EMPNO = p_EMPNO);
END UPDATE_EMP;

PROCEDURE DELETE_EMP (
p_EMPNO IN NUMBER
)
IS
BEGIN
DELETE FROM EMP
WHERE (EMPNO = p_EMPNO);
END DELETE_EMP;

PROCEDURE INSERT_EMP (
pEMPNO OUT NUMBER,
pENAME IN VARCHAR2,
pJOB IN VARCHAR2,
pMGR IN NUMBER,
pHIREDATE IN DATE,
pSAL IN NUMBER,
pCOMM IN NUMBER,
pDEPTNO IN NUMBER
)
IS
BEGIN
pEMPNO := DEVELOPER.EMPNO_SEQUENCE.NEXTVAL;
INSERT INTO "EMP" (
"EMPNO"
,"ENAME"
,"JOB"
,"MGR"
,"HIREDATE"
,"SAL"
,"COMM"
,"DEPTNO"
)
VALUES (
pEMPNO
,pENAME
,pJOB
,pMGR
,pHIREDATE
,pSAL
,pCOMM
,pDEPTNO
);
END INSERT_EMP;
END DAL_TABLE_METHODS;
What product created this syntax?

Get rid of the double quotes
Get rid of the parentheses in the WHERE clause
Add a COMMIT after your insert
Add a COMMIT after your delete

And, as requested, type SHO ERR and let us see the error.
BTW: We don't do homework so if that's the point ... YOYO!
--
Daniel A. Morgan
University of Washington
damorgan@x.washington.edu
(replace x with u to respond)
Puget Sound Oracle Users Group
www.psoug.org


Reply With Quote
Reply




Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off



Powered by vBulletin Version 3.5.3
Copyright ©2000 - 2012, Jelsoft Enterprises Ltd.